-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/overlayfs: add a switch to disable prefixing with /sysroot
for initrd mounts
#340763
Open
msanft
wants to merge
4
commits into
NixOS:master
Choose a base branch
from
msanft:msanft/overlayfs/dontprefix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Sep 9, 2024
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild
10.rebuild-linux: 1-10
labels
Sep 9, 2024
msanft
force-pushed
the
msanft/overlayfs/dontprefix
branch
from
September 10, 2024 07:02
2f7cfe8
to
c0002d4
Compare
msanft
force-pushed
the
msanft/overlayfs/dontprefix
branch
from
September 19, 2024 07:08
c0002d4
to
ea0c7c5
Compare
nikstur
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be great if you could add a test case that exercises this functionality. Maybe in tests/filesystems-overlayfs
.
msanft
force-pushed
the
msanft/overlayfs/dontprefix
branch
2 times, most recently
from
November 4, 2024 11:56
eae0c60
to
54b89b3
Compare
msanft
force-pushed
the
msanft/overlayfs/dontprefix
branch
from
November 5, 2024 09:49
ce57596
to
d2c5cc3
Compare
msanft
force-pushed
the
msanft/overlayfs/dontprefix
branch
from
November 5, 2024 16:03
d2c5cc3
to
341179b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This enables mounting paths from the initrd into the real root with the overlayfs abstraction, which can be useful in some cases, e.g. to create an overlay in the real root without a visible upper-/workdir in the real root.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.